[rsbac] bug in rsbac_kmalloc() ?

Michal Purzynski albeiro at polsl.gliwice.pl
Mon May 10 14:18:58 CEST 2004


looking at rsbac_kmalloc() implementation, i see that memory in case of 2.6 kernel is allocated like this:

kmem_cache_alloc(csizep->cs_cachep, 0)

so flags are `0`. i think it is bad - with preempt turned on flags should be GFP_ATOMIC. now with `0` flags rsbac_kmalloc() is allowed to sleep, what can lead to `bad: scheduling while atomic` errors in case of allocating memory between spinlocks.

i am going to test it with GFP_ATOMIC, and will tell about results.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
Url : http://www.rsbac.org/pipermail/rsbac/attachments/20040510/08b184ef/attachment.bin

More information about the rsbac mailing list