[rsbac] Error while umounting

[Jens Kasten]

Hi

I got this error below. Its from kernel 4.19.y

Nov 25 14:53:35 [kernel] [  277.685778] BUG: Dentry 
30bfb5e0{i=594000c,n=authfgf} name authfgf still in use (1) [unmount of 
ext4 dm-0]
Nov 25 14:53:35 [kernel] [  277.685790] ------------[ cut here 
]------------
Nov 25 14:53:35 [kernel] [  277.685819] WARNING: CPU: 0 PID: 2888 at 
fs/dcache.c:1522 umount_check+0x7c/0x94
Nov 25 14:53:35 [kernel] [  277.685839] CPU: 0 PID: 2888 Comm: umount 
Tainted: G                T 4.19.3-rsbac-9+ #18
Nov 25 14:53:35 [kernel] [  277.685845] Hardware name: Allwinner sun7i 
(A20) Family
Nov 25 14:53:35 [kernel] [  277.685884] [<c0226640>] (unwind_backtrace) 
from [<c0224004>] (show_stack+0x10/0x14)
Nov 25 14:53:35 [kernel] [  277.685908] [<c0224004>] (show_stack) from 
[<c07a0a70>] (dump_stack+0x80/0xa0)
Nov 25 14:53:35 [kernel] [  277.685931] [<c07a0a70>] (dump_stack) from 
[<c027f960>] (__warn+0xcc/0xe8)
Nov 25 14:53:35 [kernel] [  277.685952] [<c027f960>] (__warn) from 
[<c027f9b4>] (warn_slowpath_null+0x38/0x44)
Nov 25 14:53:35 [kernel] [  277.685972] [<c027f9b4>] 
(warn_slowpath_null) from [<c0366944>] (umount_check+0x7c/0x94)
Nov 25 14:53:35 [kernel] [  277.685995] [<c0366944>] (umount_check) from 
[<c0366288>] (d_walk+0x114/0x25c)
Nov 25 14:53:35 [kernel] [  277.686015] [<c0366288>] (d_walk) from 
[<c03679e0>] (do_one_tree+0x1c/0x34)
Nov 25 14:53:35 [kernel] [  277.686036] [<c03679e0>] (do_one_tree) from 
[<c0367a30>] (shrink_dcache_for_umount+0x38/0x6c)
Nov 25 14:53:35 [kernel] [  277.686062] [<c0367a30>] 
(shrink_dcache_for_umount) from [<c03513a0>] 
(generic_shutdown_super+0x1c/0x104)
Nov 25 14:53:35 [kernel] [  277.686084] [<c03513a0>] 
(generic_shutdown_super) from [<c0352274>] (kill_block_super+0x18/0x64)
Nov 25 14:53:35 [kernel] [  277.686105] [<c0352274>] (kill_block_super) 
from [<c0351020>] (deactivate_locked_super+0x50/0x80)
Nov 25 14:53:35 [kernel] [  277.686129] [<c0351020>] 
(deactivate_locked_super) from [<c036ef50>] (cleanup_mnt+0x4c/0x6c)
Nov 25 14:53:35 [kernel] [  277.686151] [<c036ef50>] (cleanup_mnt) from 
[<c029957c>] (task_work_run+0xa4/0xb8)
Nov 25 14:53:35 [kernel] [  277.686175] [<c029957c>] (task_work_run) 
from [<c0223c38>] (do_work_pending+0xa8/0xd4)
Nov 25 14:53:35 [kernel] [  277.686197] [<c0223c38>] (do_work_pending) 
from [<c0201184>] (slow_work_pending+0xc/0x20)
Nov 25 14:53:35 [kernel] [  277.686205] Exception stack(0xea79bfb0 to 
0xea79bff8)
Nov 25 14:53:35 [kernel] [  277.686218] bfa0:                            
          00000000 00000000 1d8f6300 1d8f6300
Nov 25 14:53:35 [kernel] [  277.686235] bfc0: 022bea68 b6f88934 022beb90 
00000034 b6fbb908 00000000 00000000 bee55108
Nov 25 14:53:35 [kernel] [  277.686250] bfe0: b6f88a24 bee54e84 b6f5356c 
b6ead58c 600f0010 022beb90
Nov 25 14:53:35 [kernel] [  277.686261] ---[ end trace 69f8850ec44d59d6 
]---

On rsbac-admin tools I have to insert see below, otherwise the minor and 
major macros are not available and I get an compile error.

diff --git a/main/tools/src/attr_get_file_dir.c 
b/main/tools/src/attr_get_file_dir.c
index ba1cc4f..8be8964 100644
--- a/main/tools/src/attr_get_file_dir.c
+++ b/main/tools/src/attr_get_file_dir.c
@@ -11,6 +11,7 @@
  #include <string.h>
  #include <sys/types.h>
  #include <sys/stat.h>
+#include <sys/sysmacros.h>
  #include <rsbac/types.h>
  #include <rsbac/aci_data_structures.h>
  #include <rsbac/getname.h>



Jens