[rsbac] a few problems

[Amon Ott]

--------------Boundary-00=_N6MOKA9E6Y11BX18NFOH
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

On Monday, 16. September 2002 09:37, Amon Ott wrote:
> On Friday, 13. September 2002 18:09, Josh Beagley wrote:
> > > On Monday, 9. September 2002 09:25, Josh Beagley wrote:
> > > > The first problem I seem to be having is enabling FF flags
> > > add_inherited > and secure_delete on my home directory. I am
> > > > Sep  7 02:13:02 Lynx kernel: Assertion failure in
> > > ext3_sync_file() at > fsync.c:55: "ext3_journal_current_handle()
> > > == 0" > Sep  7 02:13:02 Lynx kernel: kernel BUG at fsync.c:55!
> > > 
> > > This is caused by the RSBAC secure delete code calling fsync,
> > > although the  journal is currently open.

> > well, after recompiling rsbac with the attached patch, I created a file
> > with the contents being the word "nongoword", which I then deleted, and of
> > course i enabled secure delete for the directory the file was in. Using 
the
> > lde tool, which examines and recoveres deleted files from a ext2 
partition,
> > i was able to search for the phrase "nongoword" and recover the file.
> 
> OK, I will try to code my own fsync in ext3 to avoid the problem.

The attached patch against rsbac/adf/adf_main.c (with the previous patch, 
please change fsync code by hand otherwise) makes secdel on ext3 work fine on 
my test system. Could you please test it?

Unfortunately, secure delete seems to fail on reiserfs. Could someone else 
please try it there to verify? I'd better remove the calls from there, if it 
does not work anyway. Reiserfs seems to optimize disk writes too well...

Amon.
--
http://www.rsbac.org

--------------Boundary-00=_N6MOKA9E6Y11BX18NFOH
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="secdel.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="secdel.diff"

LS0tIGFkZl9tYWluLmN+CVRodSBTZXAgMTIgMTY6MDQ6MDYgMjAwMgorKysgYWRmX21haW4uYwlU
aHUgU2VwIDE5IDEwOjQwOjEzIDIwMDIKQEAgLTE5NTUsMTAgKzE5NTUsMTMgQEAKICAgICAgICAg
aWYgKGZpbGUuZl9vcC0+ZnN5bmMpCiAgICAgICAgICAgZXJyID0gZmlsZS5mX29wLT5mc3luYygm
ZmlsZSxkZW50cnlfcCk7CiAgICAgICAgICNlbHNlCisjaWYgMAogICAgICAgICBpZiAoICAgZmls
ZS5mX29wLT5mc3luYwogICAgICAgICAgICAgJiYgKGZpbGUuZl9vcCAhPSAmZXh0M19maWxlX29w
ZXJhdGlvbnMpCiAgICAgICAgICAgICkKICAgICAgICAgICBlcnIgPSBmaWxlLmZfb3AtPmZzeW5j
KCZmaWxlLGRlbnRyeV9wLDEpOworI2VuZGlmCisgICAgICAgIGVyciA9IGZzeW5jX2lub2RlX2Rh
dGFfYnVmZmVycyhkZW50cnlfcC0+ZF9pbm9kZSk7CiAgICAgICAgICNlbmRpZgogICAgICAgICAg
IAogICAgICAgICBpZiAoZmlsZS5mX29wLT5mbHVzaCkK

--------------Boundary-00=_N6MOKA9E6Y11BX18NFOH--