[rsbac] Kernel oops

[Amon Ott]

--------------Boundary-00=_BAREM1XUVNXWBLIXT6VL
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit

On Sunday, 10. November 2002 17:06, Mathew Johnston wrote:
> I just had a kernel oops.
> 
> I'm running RSBAC from
> http://rsbac.org/kernels/linux-2.4.19-rsbac-v1.2.1.tar.bz2 with admin
> tools http://rsbac.org/code/rsbac-admin-v1.2.1.tar.gz. I was just adding
> an ACL entry to RSBAC when it seemed to freeze, I then hit CTRL C and it
> dropped to a shell, then I tried to run rsbac_menu again, and it just
> sat there... I went to the actual machine (I had been connected via SSH)
> and there was a kernel oops displayed.
> 
> Here's the output:
> 
> Nov 10 11:06:02 lola kernel: rsbac_acl_sys_add_to_acl_entry(): adding
> rights 000000000000000000000000000000000000000000000000000 for GROUP 1
> to FILE Device 00:00 Inode 0 denied for user 0!
> Nov 10 11:06:02 lola kernel: Unable to handle kernel paging request at
> virtual address f000e36f

You were adding rights to the ACL :DEFAULT: target, and there was a kfree 
without check for this case. I had made a fix during the Systems and forgot 
to check it in the 1.2.1 tree. Sorry!

Please retry with the attached patch to rsbac/help/syscalls.c

Amon.
--
http://www.rsbac.org

--------------Boundary-00=_BAREM1XUVNXWBLIXT6VL
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="syscalls.diff"
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="syscalls.diff"

LS0tIHN5c2NhbGxzLmN+CU1vbiBPY3QgMTQgMTI6MzI6MDYgMjAwMgorKysgc3lzY2FsbHMuYwlN
b24gT2N0IDE0IDEyOjMyOjA2IDIwMDIKQEAgLTI4MTYsMTEgKzI4MTYsMTQgQEAKICAgICAgICAg
fQogCiBvdXRfZHB1dDoKLSAgICAgICNpZiBMSU5VWF9WRVJTSU9OX0NPREUgPCBLRVJORUxfVkVS
U0lPTigyLDQsMCkKLSAgICAgIGRwdXQodF9kZW50cnkpOwotICAgICAgI2Vsc2UKLSAgICAgIHBh
dGhfcmVsZWFzZSgmbmQpOwotICAgICAgI2VuZGlmCisgICAgICBpZihrX2FyZy5uYW1lKQorICAg
ICAgICB7CisgICAgICAgICAgI2lmIExJTlVYX1ZFUlNJT05fQ09ERSA8IEtFUk5FTF9WRVJTSU9O
KDIsNCwwKQorICAgICAgICAgIGRwdXQodF9kZW50cnkpOworICAgICAgICAgICNlbHNlCisgICAg
ICAgICAgcGF0aF9yZWxlYXNlKCZuZCk7CisgICAgICAgICAgI2VuZGlmCisgICAgICAgIH0KIAog
b3V0OgogICAgICAgI2lmIExJTlVYX1ZFUlNJT05fQ09ERSA8IEtFUk5FTF9WRVJTSU9OKDIsNCww
KQo=

--------------Boundary-00=_BAREM1XUVNXWBLIXT6VL--